Skip to content

Fix PyTorch matmul mixed-device operands#3636

Closed
FlorianPfaff wants to merge 3 commits into
mainfrom
fix-pytorch-matmul-device-contract
Closed

Fix PyTorch matmul mixed-device operands#3636
FlorianPfaff wants to merge 3 commits into
mainfrom
fix-pytorch-matmul-device-contract

Conversation

@FlorianPfaff

@FlorianPfaff FlorianPfaff commented Jul 1, 2026

Copy link
Copy Markdown
Owner

Summary

  • Add a PyTorch matmul compatibility hook that chooses an existing non-CPU tensor device before dtype promotion.
  • Keep raw and public PyTorch backend matmul synchronized.
  • Add focused subprocess regressions for CPU/array-like inputs combined with CUDA/meta tensors.

Bug fixed

PyTorch matmul converted operands independently and only promoted dtype. Mixed CPU plus CUDA/meta operands could then reach torch.matmul on different devices and fail.

Validation

  • Syntax-checked the new hook and regression test with py_compile.
  • Compared branch with main: ahead by 3 commits, behind by 0.
  • Full suite not run in this connector session; CI should run the focused regressions.

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

✅MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 79.71s
✅ JSON prettier 7 0 0 0 0.82s
✅ JSON v8r 7 0 0 5.01s
✅ MARKDOWN markdownlint 68 0 0 0 1.88s
✅ MARKDOWN markdown-table-formatter 68 0 0 0 0.87s
✅ PYTHON black 1186 29 0 0 65.79s
✅ PYTHON isort 1186 53 0 0 4.68s
✅ REPOSITORY checkov yes no no 49.5s
✅ REPOSITORY gitleaks yes no no 12.27s
✅ REPOSITORY git_diff yes no no 0.26s
✅ REPOSITORY secretlint yes no no 47.91s
✅ REPOSITORY syft yes no no 5.83s
✅ REPOSITORY trivy-sbom yes no no 7.49s
✅ REPOSITORY trufflehog yes no no 18.94s
✅ YAML prettier 11 0 0 0 0.84s
✅ YAML v8r 11 0 0 12.6s
✅ YAML yamllint 11 0 0 0.49s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.5.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@FlorianPfaff FlorianPfaff enabled auto-merge (squash) July 1, 2026 23:19
@FlorianPfaff

FlorianPfaff commented Jul 1, 2026

Copy link
Copy Markdown
Owner Author

Closing this conflicted PR as superseded by the main-branch PyTorch device compatibility hook repair in d4f7ba2.

auto-merge was automatically disabled July 1, 2026 23:25

Pull request was closed

@FlorianPfaff FlorianPfaff deleted the fix-pytorch-matmul-device-contract branch July 1, 2026 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@FlorianPfaff